Modified the behavior of "Hide Toolbar in Full Screen"

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
@@ skipping 367 matching lines @@
 // "" (empty string) - undecided
 // "true" - opt-in (enabled)
 const char kContextualSearchEnabled[] = "search.contextual_search_enabled";
 #endif
 
 #if defined(OS_MACOSX)
 // Boolean that indicates whether the browser should put up a confirmation
 // window when the user is attempting to quit. Mac only.
 const char kConfirmToQuitEnabled[] = "browser.confirm_to_quit";
 
-// Boolean that indicates whether the browser should hide the toolbar when it's
+// Boolean that indicates whether the browser should show the toolbar when it's
 // in fullscreen. Mac only.
-const char kHideFullscreenToolbar[] = "browser.hide_fullscreen_toolbar";

[Robert Sesek, 2016/02/26 20:42:27]

Did this pref make it to stable? Should the value be migrated?

[spqchan, 2016/02/26 23:24:59]

Not yet, but given the amount of time we have left, it may as well be.
That's a good point, how do we migrate these values?
It might be safe to not migrate this value since it's pretty minor.

Alternatively, I can change it back to the hide_fullscreen_toolbar. I'm
concerned that it will be confusing in the codebase though.

[Robert Sesek, 2016/02/29 18:05:34]

Will it make it to stable? If not, then I don't think the migration is worth it.
If this pref will make it to stable, we should migrate it IMO.

The way to do that is to keep register the new pref, migrate the value from the
old pref, clear the old pref (to prevent migration more than once), and then in
a follow-up milestone, delete the old pref.
Agreed.

+const char kShowFullscreenToolbar[] = "browser.show_fullscreen_toolbar";
 #endif
 
 // Boolean which specifies whether we should ask the user if we should download
 // a file (true) or just download it automatically.
 const char kPromptForDownload[] = "download.prompt_for_download";
 
 // A boolean pref set to true if we're using Link Doctor error pages.
 const char kAlternateErrorPagesEnabled[] = "alternate_error_pages.enabled";
 
 // An adaptively identified list of domain names to be pre-fetched during the
@@ skipping 1775 matching lines @@
 const char kMediaRouterEnableCloudServices[] =
     "media_router.cloudservices.enabled";
 #endif  // defined(GOOGLE_CHROME_BUILD)
 // Whether or not the Media Router first run flow has been acknowledged by the
 // user.
 const char kMediaRouterFirstRunFlowAcknowledged[] =
     "media_router.firstrunflow.acknowledged";
 #endif
 
 }  // namespace prefs