chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm - Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_commands_mac.cc ('K') | « chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h ('k') | chrome/browser/ui/cocoa/browser_window_command_handler.mm » ('j') | chrome/common/pref_names.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

diff --git a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

index e2a8ed0ede86f8407ec191893ec5a4e0662515b0..143e561e84323cccb6c32b2504921253674415cc 100644

--- a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

+++ b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

@@ -73,11 +73,10 @@ void ExclusiveAccessController::UpdateFullscreenWithToolbar(bool with_toolbar) {

[controller_ updateFullscreenWithToolbar:with_toolbar];

}

-void ExclusiveAccessController::ToggleFullscreenToolbar() {

+void ExclusiveAccessController::UpdateFullscreenToolbar() {

PrefService* prefs = browser_->profile()->GetPrefs();

- bool hideToolbar = !prefs->GetBoolean(prefs::kHideFullscreenToolbar);

+ bool hideToolbar = !prefs->GetBoolean(prefs::kShowFullscreenToolbar);

[controller_ setFullscreenToolbarHidden:hideToolbar];

- prefs->SetBoolean(prefs::kHideFullscreenToolbar, hideToolbar);

}

bool ExclusiveAccessController::IsFullscreenWithToolbar() const {