 Chromium Code Reviews
 Chromium Code Reviews Issue 1737413002:
  Modified the behavior of "Hide Toolbar in Full Screen"  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1737413002:
  Modified the behavior of "Hide Toolbar in Full Screen"  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/ui/cocoa/browser_window_controller.h | 
| diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h | 
| index 13bf692647c3732b57040a3296d9c92b4fbc48f0..1664adae9cba35783c59630d2b5a0a9849333df2 100644 | 
| --- a/chrome/browser/ui/cocoa/browser_window_controller.h | 
| +++ b/chrome/browser/ui/cocoa/browser_window_controller.h | 
| @@ -161,8 +161,8 @@ class Command; | 
| // return nil. | 
| BOOL isUsingCustomAnimation_; | 
| - // True if the toolbar needs to be hidden in fullscreen. | 
| - BOOL shouldHideFullscreenToolbar_; | 
| + // True if the toolbar needs to be shown in fullscreen. | 
| + BOOL shouldShowFullscreenToolbar_; | 
| // The size of the original (non-fullscreen) window. This is saved just | 
| // before entering fullscreen mode and is only valid when |-isFullscreen| | 
| @@ -534,10 +534,8 @@ class Command; | 
| // |bubbleType|. | 
| - (void)updateFullscreenExitBubble; | 
| -// Toggles and updates the toolbar's visibility in fullscreen mode. This | 
| -// function toggles between the sliding styles: OMNIBOX_TABS_PRESENT and | 
| -// OMNIBOX_TABS_HIDDEN. | 
| -- (void)setFullscreenToolbarHidden:(BOOL)isHidden; | 
| +// Set toolbar's visibility in fullscreen mode. | 
| 
msw
2016/03/01 19:23:02
nit: "Set the toolbar's"
 
spqchan
2016/03/01 23:41:31
Done.
 | 
| +- (void)setFullscreenToolbarVisible:(BOOL)visible; | 
| // Returns YES if the browser window is in or entering any fullscreen mode. | 
| - (BOOL)isInAnyFullscreenMode; | 
| @@ -563,8 +561,8 @@ class Command; | 
| // Mode. | 
| - (BOOL)inPresentationMode; | 
| -// Whether if the toolbar should be hidden in fullscreen. | 
| -- (BOOL)shouldHideFullscreenToolbar; | 
| +// Whether if the toolbar should be shown in fullscreen. | 
| 
msw
2016/03/01 19:23:02
nit: remove 'if'
 
spqchan
2016/03/01 23:41:31
Done.
 | 
| +- (BOOL)shouldShowFullscreenToolbar; | 
| // Resizes the fullscreen window to fit the screen it's currently on. Called by | 
| // the PresentationModeController when there is a change in monitor placement or |