Modified the behavior of "Hide Toolbar in Full Screen"

chrome/browser/ui/cocoa/browser_window_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 
 // A class acting as the Objective-C controller for the Browser
 // object. Handles interactions between Cocoa and the cross-platform
 // code. Each window has a single toolbar and, by virtue of being a
@@ skipping 143 matching lines @@
   // When the window is in the process of entering AppKit Fullscreen, this
   // property indicates whether the window is being fullscreened on the
   // primary screen.
   BOOL enteringAppKitFullscreenOnPrimaryScreen_;
 
   // This flag is set to true when |customWindowsToEnterFullScreenForWindow:|
   // and |customWindowsToExitFullScreenForWindow:| are called and did not
   // return nil.
   BOOL isUsingCustomAnimation_;
 
-  // True if the toolbar needs to be hidden in fullscreen.
-  BOOL shouldHideFullscreenToolbar_;
+  // True if the toolbar needs to be shown in fullscreen.
+  BOOL shouldShowFullscreenToolbar_;
 
   // The size of the original (non-fullscreen) window.  This is saved just
   // before entering fullscreen mode and is only valid when |-isFullscreen|
   // returns YES.
   NSRect savedRegularWindowFrame_;
 
   // The proportion of the floating bar which is shown (in presentation mode).
   CGFloat floatingBarShownFraction_;
 
   // Various UI elements/events may want to ensure that the floating bar is
@@ skipping 351 matching lines @@
 - (void)updateFullscreenWithToolbar:(BOOL)withToolbar;
 
 // Exits extension fullscreen if we're currently in the mode. Returns YES
 // if we exited fullscreen.
 - (BOOL)exitExtensionFullscreenIfPossible;
 
 // Updates the contents of the fullscreen exit bubble with |url| and
 // |bubbleType|.
 - (void)updateFullscreenExitBubble;
 
-// Toggles and updates the toolbar's visibility in fullscreen mode. This
-// function toggles between the sliding styles: OMNIBOX_TABS_PRESENT and
-// OMNIBOX_TABS_HIDDEN.
-- (void)setFullscreenToolbarHidden:(BOOL)isHidden;
+// Set toolbar's visibility in fullscreen mode.

[msw, 2016/03/01 19:23:02]

nit: "Set the toolbar's"

[spqchan, 2016/03/01 23:41:31]

Done.

+- (void)setFullscreenToolbarVisible:(BOOL)visible;
 
 // Returns YES if the browser window is in or entering any fullscreen mode.
 - (BOOL)isInAnyFullscreenMode;
 
 // Returns YES if the browser window is currently in or entering fullscreen via
 // the built-in immersive mechanism.
 - (BOOL)isInImmersiveFullscreen;
 
 // Returns YES if the browser window is currently in or entering fullscreen via
 // the AppKit Fullscreen API.
 - (BOOL)isInAppKitFullscreen;
 
 // Enter fullscreen for an extension.
 - (void)enterExtensionFullscreen;
 
 // Enters Immersive Fullscreen for the given URL.
 - (void)enterWebContentFullscreen;
 
 // Exits the current fullscreen mode.
 - (void)exitAnyFullscreen;
 
 // Whether the system is in the very specific fullscreen mode: Presentation
 // Mode.
 - (BOOL)inPresentationMode;
 
-// Whether if the toolbar should be hidden in fullscreen.
-- (BOOL)shouldHideFullscreenToolbar;
+// Whether if the toolbar should be shown in fullscreen.

[msw, 2016/03/01 19:23:02]

nit: remove 'if'

[spqchan, 2016/03/01 23:41:31]

Done.

+- (BOOL)shouldShowFullscreenToolbar;
 
 // Resizes the fullscreen window to fit the screen it's currently on.  Called by
 // the PresentationModeController when there is a change in monitor placement or
 // resolution.
 - (void)resizeFullscreenWindow;
 
 // Query/lock/release the requirement that the tab strip/toolbar/attached
 // bookmark bar bar cluster is visible (e.g., when one of its elements has
 // focus). This is required for the floating bar in presentation mode, but
 // should also be called when not in presentation mode; see the comments for
@@ skipping 63 matching lines @@
 // Returns the active tab contents controller's |blockFullscreenResize_| flag.
 - (BOOL)isActiveTabContentsControllerResizeBlocked;
 
 // Returns the presentation mode controller.
 - (PresentationModeController*)presentationModeController;
 
 @end  // @interface BrowserWindowController (TestingAPI)
 
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_