Modified the behavior of "Hide Toolbar in Full Screen"

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index ca1fb51cf51a9a6ba2e7b00f4801f4d2c7b87fe5..855d0f2e05dedbb42f4a21a2cc1429dd73346377 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -437,6 +437,19 @@ Browser::Browser(const CreateParams& params)
       base::Bind(&Browser::UpdateBookmarkBarState, base::Unretained(this),
                  BOOKMARK_BAR_STATE_CHANGE_PREF_CHANGE));
 
+#if defined(OS_MACOSX)
+  // Migrate the value of kHideFullscreenToolbar to kShowFullscreenToolbar if

[msw, 2016/03/01 19:23:02]

I think this belongs in MigrateObsoleteProfilePrefs.

[spqchan, 2016/03/01 23:41:31]

Sounds good! I moved the code into MigrateObsoleteProfilePrefs.

+  // it was set by the user. See crbug.com/590827.
+  PrefService* prefs = profile_->GetPrefs();
+  const PrefService::Preference* hide_pref =
+      prefs->FindPreference(prefs::kHideFullscreenToolbar);
+  if (!hide_pref->IsDefaultValue()) {
+    bool hide_pref_value = prefs->GetBoolean(prefs::kHideFullscreenToolbar);
+    prefs->SetBoolean(prefs::kShowFullscreenToolbar, !hide_pref_value);
+    prefs->ClearPref(prefs::kHideFullscreenToolbar);
+  }
+#endif
+
   // NOTE: These prefs all need to be explicitly destroyed in the destructor
   // or you'll get a nasty surprise when you run the incognito tests.
   encoding_auto_detect_.Init(prefs::kWebKitUsesUniversalDetector,