Modified the behavior of "Hide Toolbar in Full Screen"

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 419 matching lines @@
 
   profile_pref_registrar_.Init(profile_->GetPrefs());
   profile_pref_registrar_.Add(
       prefs::kDevToolsDisabled,
       base::Bind(&Browser::OnDevToolsDisabledChanged, base::Unretained(this)));
   profile_pref_registrar_.Add(
       bookmarks::prefs::kShowBookmarkBar,
       base::Bind(&Browser::UpdateBookmarkBarState, base::Unretained(this),
                  BOOKMARK_BAR_STATE_CHANGE_PREF_CHANGE));
 
+#if defined(OS_MACOSX)
+  // Migrate the value of kHideFullscreenToolbar to kShowFullscreenToolbar if

[msw, 2016/03/01 19:23:02]

I think this belongs in MigrateObsoleteProfilePrefs.

[spqchan, 2016/03/01 23:41:31]

Sounds good! I moved the code into MigrateObsoleteProfilePrefs.

+  // it was set by the user. See crbug.com/590827.
+  PrefService* prefs = profile_->GetPrefs();
+  const PrefService::Preference* hide_pref =
+      prefs->FindPreference(prefs::kHideFullscreenToolbar);
+  if (!hide_pref->IsDefaultValue()) {
+    bool hide_pref_value = prefs->GetBoolean(prefs::kHideFullscreenToolbar);
+    prefs->SetBoolean(prefs::kShowFullscreenToolbar, !hide_pref_value);
+    prefs->ClearPref(prefs::kHideFullscreenToolbar);
+  }
+#endif
+
   // NOTE: These prefs all need to be explicitly destroyed in the destructor
   // or you'll get a nasty surprise when you run the incognito tests.
   encoding_auto_detect_.Init(prefs::kWebKitUsesUniversalDetector,
                              profile_->GetPrefs());
 
   if (search::IsInstantExtendedAPIEnabled() && is_type_tabbed())
     instant_controller_.reset(new BrowserInstantController(this));
 
   if (extensions::HostedAppBrowserController::IsForHostedApp(this)) {
     hosted_app_controller_.reset(
@@ skipping 2284 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         ui::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }