Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1737213002: EME: Remove WidevineCdmType. (Closed)

Created:
4 years, 10 months ago by ddorwin
Modified:
4 years, 9 months ago
Reviewers:
xhwang, halliwell
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, eme-reviews_chromium.org, halliwell+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@parent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Remove WidevineCdmType. This only applied to prefixed EME. BUG=249976 Committed: https://crrev.com/fb556f50ebf8c7e20960e57f516322fed34a8ec0 Cr-Commit-Position: refs/heads/master@{#377917}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix Cast build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -47 lines) Patch
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/cdm/renderer/android_key_systems.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M components/cdm/renderer/widevine_key_systems.h View 1 chunk +0 lines, -8 lines 0 comments Download
M components/cdm/renderer/widevine_key_systems.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Issue 1732423002 Patch 40001

Messages

Total messages: 17 (7 generated)
ddorwin
4 years, 10 months ago (2016-02-25 18:53:52 UTC) #2
ddorwin
halliwell: Please OWNERS review the Cast file.
4 years, 10 months ago (2016-02-25 18:54:42 UTC) #4
xhwang
I can't remember what those are for ;) But LGTM!
4 years, 10 months ago (2016-02-25 19:04:29 UTC) #5
halliwell
On 2016/02/25 19:04:29, xhwang wrote: > I can't remember what those are for ;) But ...
4 years, 10 months ago (2016-02-25 22:48:43 UTC) #6
ddorwin
On 2016/02/25 22:48:43, halliwell wrote: > On 2016/02/25 19:04:29, xhwang wrote: > > I can't ...
4 years, 10 months ago (2016-02-26 00:04:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737213002/40001
4 years, 10 months ago (2016-02-26 01:33:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/186210)
4 years, 10 months ago (2016-02-26 01:56:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737213002/40001
4 years, 9 months ago (2016-02-26 17:13:14 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-26 18:00:46 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 18:02:31 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fb556f50ebf8c7e20960e57f516322fed34a8ec0
Cr-Commit-Position: refs/heads/master@{#377917}

Powered by Google App Engine
This is Rietveld 408576698