Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 1732423002: EME: Remove the concept of a parent key system. (Closed)

Created:
4 years, 9 months ago by ddorwin
Modified:
4 years, 9 months ago
Reviewers:
jrummell
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Remove the concept of a parent key system. This was only used by prefixed EME. We still check whether a key system is a "subdomain" in a few specific cases. BUG=249976 Committed: https://crrev.com/40312dfef0268efa7d153a18dde861db685008a9 Cr-Commit-Position: refs/heads/master@{#377755}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Add test per review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -90 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M components/cdm/renderer/widevine_key_systems.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M media/base/key_system_info.h View 2 chunks +0 lines, -11 lines 0 comments Download
M media/base/key_systems.cc View 1 6 chunks +1 line, -18 lines 0 comments Download
M media/base/key_systems_unittest.cc View 1 2 6 chunks +3 lines, -37 lines 0 comments Download
M media/cdm/key_system_names.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cdm/key_system_names.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
ddorwin
4 years, 9 months ago (2016-02-25 18:02:34 UTC) #2
ddorwin
4 years, 9 months ago (2016-02-25 18:07:19 UTC) #3
jrummell
lgtm https://codereview.chromium.org/1732423002/diff/1/media/base/key_systems_unittest.cc File media/base/key_systems_unittest.cc (right): https://codereview.chromium.org/1732423002/diff/1/media/base/key_systems_unittest.cc#newcode474 media/base/key_systems_unittest.cc:474: EXPECT_FALSE(IsSupportedKeySystem("x-org.example.")); Should we add a test that parents ...
4 years, 9 months ago (2016-02-25 19:28:07 UTC) #4
ddorwin
https://codereview.chromium.org/1732423002/diff/1/media/base/key_systems_unittest.cc File media/base/key_systems_unittest.cc (right): https://codereview.chromium.org/1732423002/diff/1/media/base/key_systems_unittest.cc#newcode474 media/base/key_systems_unittest.cc:474: EXPECT_FALSE(IsSupportedKeySystem("x-org.example.")); On 2016/02/25 19:28:07, jrummell wrote: > Should we ...
4 years, 9 months ago (2016-02-25 20:43:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732423002/40001
4 years, 9 months ago (2016-02-25 23:29:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-26 01:25:08 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 01:27:54 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40312dfef0268efa7d153a18dde861db685008a9
Cr-Commit-Position: refs/heads/master@{#377755}

Powered by Google App Engine
This is Rietveld 408576698