Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1736963002: Remove strong mode support from count operations. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from count operations. R=bmeurer@chromium.org BUG=v8:3956 LOG=n Committed: https://crrev.com/ee250655b45a969b399a4ab5490c8c5d1b38ed96 Cr-Commit-Position: refs/heads/master@{#34286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -76 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1738653003 Patch 1

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-25 11:41:47 UTC) #1
Benedikt Meurer
Awesome! LGTM
4 years, 10 months ago (2016-02-25 11:42:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736963002/1
4 years, 10 months ago (2016-02-25 11:56:16 UTC) #4
rmcilroy
lgtm.
4 years, 10 months ago (2016-02-25 12:08:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 12:11:53 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 12:13:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ee250655b45a969b399a4ab5490c8c5d1b38ed96
Cr-Commit-Position: refs/heads/master@{#34286}

Powered by Google App Engine
This is Rietveld 408576698