third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1736893002: Update drag images to paint from the nearest self painting layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1736893002: Update drag images to paint from the nearest self painting layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a performance note and prepare this ship for landing. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index 2a34031c6b1d79a03a3b2f3a87ac1de8cee6a7d8..4ae5132c89708c12992b47244806223ba351709d 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -2452,6 +2452,14 @@ void PaintLayer::updateSelfPaintingLayer()

parent()->dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();

}

+PaintLayer* PaintLayer::enclosingSelfPaintingLayer()

+ PaintLayer* layer = this;

+ while (layer && !layer->isSelfPaintingLayer())

+ layer = layer->parent();

+ return layer;

bool PaintLayer::hasNonEmptyChildLayoutObjects() const

{

// Some HTML can cause whitespace text nodes to have layoutObjects, like:

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »