Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1736483002: Documentation: sync-and-gyp design document (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-02-24 (Wednesday) 10:22:51 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A site/dev/design/sync-and-gyp.md View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hal.canary
PTAL
4 years, 10 months ago (2016-02-24 15:24:29 UTC) #4
hcm
On 2016/02/24 15:24:29, Hal Canary wrote: > PTAL LGTM, thanks! Should we also recommend & ...
4 years, 10 months ago (2016-02-24 18:27:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736483002/20001
4 years, 10 months ago (2016-02-24 18:49:49 UTC) #7
hal.canary
On 2016/02/24 at 18:27:01, hcm wrote: > On 2016/02/24 15:24:29, Hal Canary wrote: > > ...
4 years, 10 months ago (2016-02-24 18:50:37 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:50:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1cc345f6994c6817f47d712ef8e85b76337d44e3

Powered by Google App Engine
This is Rietveld 408576698