src/effects/SkEmbossMaskFilter.cpp - Issue 173633003: Factory methods for heap-allocated SkMaskFilter objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkEmbossMaskFilter.cpp

Issue 173633003: Factory methods for heap-allocated SkMaskFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkEmbossMaskFilter.cpp

diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp

index 6747bf5b388ab7373e9dea6d44aa64b6bb15eab5..0a21d41b22f6e770348fcdd7485c339db9a9e45b 100644

--- a/src/effects/SkEmbossMaskFilter.cpp

+++ b/src/effects/SkEmbossMaskFilter.cpp

@@ -49,7 +49,7 @@ SkMaskFilter* SkBlurMaskFilter::CreateEmboss(SkScalar blurSigma, const SkScalar

light.fAmbient = SkToU8(am);

light.fSpecular = SkToU8(sp);

- return SkNEW_ARGS(SkEmbossMaskFilter, (blurSigma, light));

+ return SkEmbossMaskFilter::Create(blurSigma, light);

}

///////////////////////////////////////////////////////////////////////////////

« include/effects/SkTableMaskFilter.h ('K') | « samplecode/SampleEmboss.cpp ('k') | no next file » | no next file with comments »