Factory methods for heap-allocated SkMaskFilter objects.

include/effects/SkTableMaskFilter.h

Index: include/effects/SkTableMaskFilter.h
diff --git a/include/effects/SkTableMaskFilter.h b/include/effects/SkTableMaskFilter.h
index 1c2bbd7a1b6c6fa65f87de461494856ff46bb664..6788acc781012f40311a1c9c0726c289e1eb171b 100644
--- a/include/effects/SkTableMaskFilter.h
+++ b/include/effects/SkTableMaskFilter.h
@@ -18,8 +18,6 @@
  */
 class SK_API SkTableMaskFilter : public SkMaskFilter {
 public:
-    SkTableMaskFilter();
-    SkTableMaskFilter(const uint8_t table[256]);
     virtual ~SkTableMaskFilter();
 
     /** Utility that sets the gamma table
@@ -54,6 +52,12 @@ protected:
     SkTableMaskFilter(SkReadBuffer& rb);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
+#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
+public:
+#endif
+    SkTableMaskFilter();
+    SkTableMaskFilter(const uint8_t table[256]);

[scroggo, 2014/02/20 14:17:07]

Please add a factory for this constructor, which is called by Android.

[Dominik Grewe, 2014/02/20 16:38:11]

Good spot, thanks. I just assumed everyone only used the provided factory
methods.

+
 private:
     uint8_t fTable[256];