Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java |
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java |
index f10f973bee79645bda12d96c1c4437adab6456c4..7019f8be407710c9a5c62cb1b35b37f6d1de8372 100644 |
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java |
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java |
@@ -706,6 +706,28 @@ public class ContextualSearchUma { |
} |
/** |
+ * Logs the duration from starting a search until the Search Term is Resolved. |
+ * @param durationMs The duration to record. |
+ */ |
+ public static void logSearchTermResolution(long durationMs) { |
pedro (no code reviews)
2016/02/26 22:30:09
Nit: logSearchTermResolution --> logSearchTermReso
Donn Denman
2016/02/27 00:18:40
Done.
|
+ RecordHistogram.recordMediumTimesHistogram( |
+ "Search.ContextualSearchResolutionDuration", durationMs, TimeUnit.MILLISECONDS); |
+ } |
+ |
+ /** |
+ * Logs the duration from starting a search until the results in the SERP start to become |
+ * viewable. Should be called only for searches that are prefetched. |
+ * @param durationMs The duration to record. |
+ * @param didResolve Whether a Search Term Resolution was required as part of the loading. |
+ */ |
+ public static void logSearchResultsViewable(long durationMs, boolean didResolve) { |
+ String histogramName = didResolve ? "Search.ContextualSearchResolvedResultsViewableDuration" |
+ : "Search.ContextualSearchLiteralResultsViewableDuration"; |
pedro (no code reviews)
2016/02/26 22:30:10
I thought "literal" / verbatim results were never
Donn Denman
2016/02/27 00:18:39
No, with the opt-out on HTTPS pages we usually do
pedro (no code reviews)
2016/02/27 00:39:04
I see. In this case, nevermind.
|
+ RecordHistogram.recordMediumTimesHistogram( |
+ histogramName, durationMs, TimeUnit.MILLISECONDS); |
+ } |
+ |
+ /** |
* Logs whether the promo was seen. |
pedro (no code reviews)
2016/02/26 22:30:09
Shouldn't we also log the time it takes to establi
Donn Denman
2016/02/27 00:18:39
Are you asking about the initial selection that ha
pedro (no code reviews)
2016/02/27 00:39:04
Yes, I'm asking about the initial selection. I tho
Donn Denman
2016/02/29 17:54:11
The idea of not establishing an initial selection
|
* Logs multiple histograms, with and without the original triggering gesture. |
* @param wasPanelSeen Whether the panel was seen. |