[Contextual Search] Add metrics for Resolve and View timing

chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.compositor.bottombar.contextualsearch;
 
 import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;
 import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
 import org.chromium.chrome.browser.contextualsearch.ContextualSearchUma;
 
@@ skipping 170 matching lines @@
             assert mSearchViewStartTimeNs != 0;
             long durationMs = (System.nanoTime() - mSearchViewStartTimeNs) / 1000000;
             logSearchPanelLoadDuration(wasPrefetch, durationMs);
         }
 
         // Not yet opened, wait till an open to log.
         mIsSearchPanelFullyPreloaded = true;
     }
 
     /**
+     * Called when a search term has been resolved.
+     * Currently this just logs time between initiating the search and resolving the search term
+     * into the uma metrics.
+     */
+    public void onSearchTermResolved() {
+        long durationMs = (System.nanoTime() - mSearchViewStartTimeNs) / 1000000;

[Theresa, 2016/02/29 19:42:44]

mSearchViewStartTimeNs is set in onSeachPanelFirstView() which only gets called
when exiting from peeked. I think we may want mSearchStartTimeNs, which is set
to System.nanoTime() if a new search is starting.

[Donn Denman, 2016/03/01 21:18:07]

Wow, that was a big mistake.  Thanks for catching that!

+        ContextualSearchUma.logSearchTermResolutionDuration(durationMs);
+    }
+
+    /**
+     * Called when navigation to prefetched search results first become viewable in the panel.
+     * Currently this just logs time-till-navigated into the uma metrics.

[Theresa, 2016/02/29 19:42:44]

I think the wording on this docstring and "time-till-navigated" is confusing
too. It might be more clear if the comment said something about the panel
navigating to search results resulting in the search results being viewable.
Initially I was wondering what/who navigated to the search results.

[Donn Denman, 2016/03/01 21:18:07]

Done.

+     */
+    public void onPrefetchedSearchNavigated(boolean didResolve) {
+        long durationMs = (System.nanoTime() - mSearchViewStartTimeNs) / 1000000;
+        ContextualSearchUma.logPrefetchedSearchNavigatedDuration(durationMs, didResolve);
+    }
+
+    /**
      * Records timing information when the search panel has been viewed for the first time.
      */
     private void onSearchPanelFirstView() {
         if (mIsSearchPanelFullyPreloaded) {
             // Already fully pre-loaded, record a wait of 0 milliseconds.
             logSearchPanelLoadDuration(true, 0);
         } else {
             // Start a loading timer.
             mSearchViewStartTimeNs = System.nanoTime();
         }
@@ skipping 35 matching lines @@
     /**
      * Logs the duration the user waited for the search panel to fully load, once it was opened.
      * @param wasPrefetch Whether the load included prefetch.
      * @param durationMs The duration to log.
      */
     private void logSearchPanelLoadDuration(boolean wasPrefetch, long durationMs) {
         ContextualSearchUma.logSearchPanelLoadDuration(wasPrefetch, durationMs);
     }
 }