Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: tests/standalone/53bit_overflow_test.dart

Issue 17361004: Move FiftythreeBitOverflowError to VM-only patch file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/errors.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/53bit_overflow_test.dart
diff --git a/tests/standalone/53bit_overflow_test.dart b/tests/standalone/53bit_overflow_test.dart
index 256e66a900ae1a10604f4d45937e943068bb8bcd..19eac48dd29c28b7972140ced111af368fbe9461 100644
--- a/tests/standalone/53bit_overflow_test.dart
+++ b/tests/standalone/53bit_overflow_test.dart
@@ -61,20 +61,20 @@ main() {
// Run the tests once before optimizations.
dti_arg = 1.9e16;
- Expect.throws(double_to_int, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(double_to_int, (e) => e is Error);
floitsch 2013/06/20 14:48:27 isn't the error still visible?
zra 2013/06/20 15:45:24 If the error is still visible, I think it would be
srdjan 2013/06/20 16:06:08 ditto
Lasse Reichstein Nielsen 2013/06/21 05:41:49 Argh. The error was NOT supposed to be visible. Wi
ia_arg1 = (1 << 51);
ia_arg2 = (1 << 51);
- Expect.throws(integer_add, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(integer_add, (e) => e is Error);
n_arg = -0xFFFFFFFFFFFFF - 1;
- Expect.throws(negate, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(negate, (e) => e is Error);
is_arg = (1 << 51);
- Expect.throws(integer_shift, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(integer_shift, (e) => e is Error);
- Expect.throws(max_add_throws, (e) => e is FiftyThreeBitOverflowError);
- Expect.throws(min_sub_throws, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(max_add_throws, (e) => e is Error);
+ Expect.throws(min_sub_throws, (e) => e is Error);
for (int i = 0; i < 20; i++) {
dti_arg = i.toDouble();
@@ -98,18 +98,18 @@ main() {
// The optimized functions should now deoptimize and throw the error.
dti_arg = 1.9e16;
- Expect.throws(double_to_int, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(double_to_int, (e) => e is Error);
ia_arg1 = (1 << 51);
ia_arg2 = (1 << 51);
- Expect.throws(integer_add, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(integer_add, (e) => e is Error);
n_arg = -0xFFFFFFFFFFFFF - 1;
- Expect.throws(negate, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(negate, (e) => e is Error);
is_arg = (1 << 51);
- Expect.throws(integer_shift, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(integer_shift, (e) => e is Error);
- Expect.throws(max_add_throws, (e) => e is FiftyThreeBitOverflowError);
- Expect.throws(min_sub_throws, (e) => e is FiftyThreeBitOverflowError);
+ Expect.throws(max_add_throws, (e) => e is Error);
+ Expect.throws(min_sub_throws, (e) => e is Error);
}
« no previous file with comments | « sdk/lib/core/errors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698