Move FiftythreeBitOverflowError to VM-only patch file.

tests/standalone/53bit_overflow_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VMOptions=--throw_on_javascript_int_overflow --optimization_counter_threshold=10
 
 
 import "package:expect/expect.dart";
 import 'dart:typed_data';
 
@@ skipping 43 matching lines @@
   return min_literal;
 }
 
 
 main() {
   Expect.equals(0xFFFFFFFFFFFFF, max_literal());
   Expect.equals(-0xFFFFFFFFFFFFF - 1, min_literal());
 
   // Run the tests once before optimizations.
   dti_arg = 1.9e16;
-  Expect.throws(double_to_int, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(double_to_int, (e) => e is Error);

[floitsch, 2013/06/20 14:48:27]

isn't the error still visible?

[zra, 2013/06/20 15:45:24]

If the error is still visible, I think it would be good to be explicit about
which exception is expected.

[srdjan, 2013/06/20 16:06:08]

ditto

[Lasse Reichstein Nielsen, 2013/06/21 05:41:49]

Argh. The error was NOT supposed to be visible.
Will fix that.

 
   ia_arg1 = (1 << 51);
   ia_arg2 = (1 << 51);
-  Expect.throws(integer_add, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(integer_add, (e) => e is Error);
 
   n_arg = -0xFFFFFFFFFFFFF - 1;
-  Expect.throws(negate, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(negate, (e) => e is Error);
 
   is_arg = (1 << 51);
-  Expect.throws(integer_shift, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(integer_shift, (e) => e is Error);
 
-  Expect.throws(max_add_throws, (e) => e is FiftyThreeBitOverflowError);
-  Expect.throws(min_sub_throws, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(max_add_throws, (e) => e is Error);
+  Expect.throws(min_sub_throws, (e) => e is Error);
 
   for (int i = 0; i < 20; i++) {
     dti_arg = i.toDouble();
     // Expect.throws calls through the closure, so we have to here, too.
     var f = double_to_int;
     Expect.equals(i, f());
 
     ia_arg1 = i;
     ia_arg2 = i;
     f = integer_add;
     Expect.equals(i + i, f());
 
     n_arg = i;
     f = negate;
     Expect.equals(-i, f());
 
     is_arg = i;
     f = integer_shift;
     Expect.equals(i << 1, f());
   }
 
   // The optimized functions should now deoptimize and throw the error.
   dti_arg = 1.9e16;
-  Expect.throws(double_to_int, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(double_to_int, (e) => e is Error);
 
   ia_arg1 = (1 << 51);
   ia_arg2 = (1 << 51);
-  Expect.throws(integer_add, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(integer_add, (e) => e is Error);
 
   n_arg = -0xFFFFFFFFFFFFF - 1;
-  Expect.throws(negate, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(negate, (e) => e is Error);
 
   is_arg = (1 << 51);
-  Expect.throws(integer_shift, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(integer_shift, (e) => e is Error);
 
-  Expect.throws(max_add_throws, (e) => e is FiftyThreeBitOverflowError);
-  Expect.throws(min_sub_throws, (e) => e is FiftyThreeBitOverflowError);
+  Expect.throws(max_add_throws, (e) => e is Error);
+  Expect.throws(min_sub_throws, (e) => e is Error);
 }