Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: gpu/command_buffer/tests/gl_manager.h

Issue 1736093002: Add a workaround for copyTexImage2D as it is sometimes broken on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from kbr. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/gl_manager.h
diff --git a/gpu/command_buffer/tests/gl_manager.h b/gpu/command_buffer/tests/gl_manager.h
index 4ee1389c5c13cb0064aaf686470a2758abbe5892..25b62ab1920f83aad47451f412a5873764242a24 100644
--- a/gpu/command_buffer/tests/gl_manager.h
+++ b/gpu/command_buffer/tests/gl_manager.h
@@ -78,7 +78,7 @@ class GLManager : private GpuControl {
GLManager();
~GLManager() override;
- static scoped_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
+ scoped_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
const gfx::Size& size,
gfx::BufferFormat format);
@@ -93,6 +93,8 @@ class GLManager : private GpuControl {
void SetSurface(gfx::GLSurface* surface);
+ void SetUseIOSurfaceMemoryBuffers(bool use_iosurface_memory_buffers);
Zhenyao Mo 2016/03/15 17:40:47 Nit: setter function should be named set_use_iosur
erikchen 2016/03/15 18:08:38 Done. Note that technically, Chrome style require
+
void SetCommandsPaused(bool paused) { pause_commands_ = paused; }
gles2::GLES2Decoder* decoder() const {
@@ -175,6 +177,8 @@ class GLManager : private GpuControl {
const CommandBufferId command_buffer_id_;
uint64_t next_fence_sync_release_;
+ bool use_iosurface_memory_buffers_ = false;
Zhenyao Mo 2016/03/15 17:40:48 Is this even legal? Shouldn't it be initialized in
erikchen 2016/03/15 18:08:38 This is a C++ 11 feature called in-class member in
+
// Used on Android to virtualize GL for all contexts.
static int use_count_;
static scoped_refptr<gfx::GLShareGroup>* base_share_group_;

Powered by Google App Engine
This is Rietveld 408576698