Add a workaround for copyTexImage2D as it is sometimes broken on OSX.

gpu/command_buffer/tests/gl_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_TESTS_GL_MANAGER_H_
 #define GPU_COMMAND_BUFFER_TESTS_GL_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 60 matching lines @@
     bool lose_context_when_out_of_memory;
     // Whether or not it's ok to lose the context.
     bool context_lost_allowed;
     gles2::ContextType context_type;
     // Force shader name hashing for all context types.
     bool force_shader_name_hashing;
   };
   GLManager();
   ~GLManager() override;
 
-  static scoped_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
+  scoped_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
       const gfx::Size& size,
       gfx::BufferFormat format);
 
   void Initialize(const Options& options);
   void InitializeWithCommandLine(const Options& options,
                                  base::CommandLine* command_line);
   void Destroy();
 
   bool IsInitialized() const { return gles2_implementation() != nullptr; }
 
   void MakeCurrent();
 
   void SetSurface(gfx::GLSurface* surface);
 
+  void SetUseIOSurfaceMemoryBuffers(bool use_iosurface_memory_buffers);

[Zhenyao Mo, 2016/03/15 17:40:47]

Nit: setter function should be named set_use_iosurface_memory_buffers()

[erikchen, 2016/03/15 18:08:38]

Done.

Note that technically, Chrome style requires that inline functions use the style
you mentioned. Setters, like SetSurface() on line 94, whose implementation is in
the .cc file continue to use CapsLikeThis.

+
   void SetCommandsPaused(bool paused) { pause_commands_ = paused; }
 
   gles2::GLES2Decoder* decoder() const {
     return decoder_.get();
   }
 
   gles2::MailboxManager* mailbox_manager() const {
     return mailbox_manager_.get();
   }
 
@@ skipping 62 matching lines @@
   scoped_ptr<gles2::GLES2CmdHelper> gles2_helper_;
   scoped_ptr<TransferBuffer> transfer_buffer_;
   scoped_ptr<gles2::GLES2Implementation> gles2_implementation_;
   bool context_lost_allowed_;
   bool pause_commands_;
   uint32_t paused_order_num_;
 
   const CommandBufferId command_buffer_id_;
   uint64_t next_fence_sync_release_;
 
+  bool use_iosurface_memory_buffers_ = false;

[Zhenyao Mo, 2016/03/15 17:40:48]

Is this even legal? Shouldn't it be initialized in the constructor instead?

[erikchen, 2016/03/15 18:08:38]

This is a C++ 11 feature called in-class member initialization, and is allowed
by the Chrome style guide.

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/zqB-DySA4V0

+
   // Used on Android to virtualize GL for all contexts.
   static int use_count_;
   static scoped_refptr<gfx::GLShareGroup>* base_share_group_;
   static scoped_refptr<gfx::GLSurface>* base_surface_;
   static scoped_refptr<gfx::GLContext>* base_context_;
 };
 
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_TESTS_GL_MANAGER_H_