Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2943)

Unified Diff: blimp/docs/fonts.md

Issue 1735783002: Add Android fonts to blimp engine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@khushal-fonts
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/docs/fonts.md
diff --git a/blimp/docs/fonts.md b/blimp/docs/fonts.md
new file mode 100644
index 0000000000000000000000000000000000000000..ad9a000ec8ca8c7d0a51f1f97ce2ddf30f4f2867
--- /dev/null
+++ b/blimp/docs/fonts.md
@@ -0,0 +1,36 @@
+# Updating Blimp Fonts
+
+1. Clone the git-repositories listed in `//blimp/fonts/README.chromium`, and roll
+ forward to the commit you want.
+1. Copy the necessary files to `//blimp/fonts`.
+1. Verify that the `LICENSE` file is still up to date and lists all relevant
+ licenses and which fonts use which license.
+1. Update the `//blimp/fonts:fonts` target to include all the current fonts and
+ their license files.
+1. Update the engine dependencies using
+ `//blimp/tools/generate-engine-manifest.py`. This step is documented in
+ `//blimp/docs/container.md`.
+1. Run the `upload_to_google_storage.py` (from depot_tools) script to upload the
+ files. To do this, execute:
+
+ ```bash
+ $ find ./blimp/fonts -regex '^.*.\(ttf\|otf\)$' -type f -print0 | \
maniscalco 2016/02/25 00:56:54 We usually omit the $ prompt in ```bash``` section
nyquist 2016/02/25 01:16:40 Doh! My bad. Removed.
+ upload_to_google_storage.py --use_null_terminator -b chromium-fonts -
+ ```
+
+ If the set of fonts includes more than `.ttf` or `.otf` files, you must update
maniscalco 2016/02/25 00:56:54 What do we wrap our .md's to? 80 cols? Wrapping
nyquist 2016/02/25 01:16:40 Doh! My bad. I had '* ' before, and that took up t
+ the regular expression to include such fonts.
+1. Verify that `//blimp/fonts/.gitignore` lists the correct files to ignore.
+1. Add all the `.sha1` files to the chromium src repository, by executing the
+ following command:
+
+ ```bash
+ git add ./blimp/fonts/*.sha1
+ ```
+
+1. Commit and upload the change for review:
+
+ ```bash
+ git commit
+ git cl upload
+ ```

Powered by Google App Engine
This is Rietveld 408576698