Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1735523003: Improve handling of invalid command line in Me2Me host. (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@win_threads
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve handling of invalid command line in Me2Me host. Previously the host was DCHECK'ing in remoting::ExitCodeToString() when started with invalid command line. This was happening because kHostExitCodeStrings didn't contain all possible error codes. Also the host was trying to report offline reason, but it makes no sense to report offline reason in this case. Committed: https://crrev.com/7e16a84c48423858ca62cd26e46f7dd00c3f96eb Cr-Commit-Position: refs/heads/master@{#377472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M remoting/host/desktop_process_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_exit_codes.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_exit_codes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/host_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/host/win/host_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 9 months ago (2016-02-25 01:03:57 UTC) #2
Lambros
lgtm
4 years, 9 months ago (2016-02-25 01:14:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735523003/1
4 years, 9 months ago (2016-02-25 01:55:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-25 02:39:46 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 02:42:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e16a84c48423858ca62cd26e46f7dd00c3f96eb
Cr-Commit-Position: refs/heads/master@{#377472}

Powered by Google App Engine
This is Rietveld 408576698