Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1673723002: Use IpcVideoFrameCapturer on network thread instead of capturer thread. (Closed)

Created:
4 years, 10 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IpcVideoFrameCapturer on network thread instead of capture thread. Previously IpcVideoFrameCapturer was called on the capturer thread, while all IPC messages are sent and received on the network thread. Now DesktopEnvironment implementations are responsible for creation of DesktopCapturerProxy and MouseCursorMonitorProxy if necessary. This allows to avoid capture thread on windows in the network process. Also cleaned up unnecessary references to various task runners from ChromotingHost and ClientSession. BUG=458437 Committed: https://crrev.com/85df3c48fd4a3be69b1a650cebc793024d4879b3 Cr-Commit-Position: refs/heads/master@{#375412}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -330 lines) Patch
M remoting/host/basic_desktop_environment.h View 1 2 6 chunks +18 lines, -0 lines 0 comments Download
M remoting/host/basic_desktop_environment.cc View 1 2 3 4 5 6 4 chunks +23 lines, -14 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 2 3 chunks +6 lines, -17 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 2 chunks +2 lines, -12 lines 0 comments Download
M remoting/host/client_session.h View 1 2 3 4 5 6 2 chunks +7 lines, -18 lines 0 comments Download
M remoting/host/client_session.cc View 1 2 4 chunks +2 lines, -22 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 2 3 4 1 chunk +3 lines, -9 lines 0 comments Download
M remoting/host/desktop_process_main.cc View 1 2 3 4 5 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +12 lines, -0 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 1 2 3 4 5 6 7 8 3 chunks +1 line, -13 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 1 2 3 4 5 6 7 8 5 chunks +12 lines, -40 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 3 chunks +0 lines, -11 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 6 chunks +11 lines, -33 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 1 2 3 4 chunks +6 lines, -11 lines 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 2 3 4 5 6 3 chunks +11 lines, -29 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -9 lines 0 comments Download
M remoting/host/it2me_desktop_environment.h View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/it2me_desktop_environment.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/me2me_desktop_environment.h View 1 2 3 4 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/me2me_desktop_environment.cc View 1 2 3 4 5 6 3 chunks +13 lines, -9 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 4 5 6 7 2 chunks +12 lines, -22 lines 0 comments Download
M remoting/host/single_window_desktop_environment.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/single_window_desktop_environment.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M remoting/host/win/session_desktop_environment.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/win/session_desktop_environment.cc View 1 2 3 4 1 chunk +10 lines, -7 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (15 generated)
Sergey Ulanov
4 years, 10 months ago (2016-02-05 20:41:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673723002/60001
4 years, 10 months ago (2016-02-05 21:04:17 UTC) #7
joedow
lgtm https://codereview.chromium.org/1673723002/diff/60001/remoting/host/ipc_desktop_environment.h File remoting/host/ipc_desktop_environment.h (right): https://codereview.chromium.org/1673723002/diff/60001/remoting/host/ipc_desktop_environment.h#newcode134 remoting/host/ipc_desktop_environment.h:134: // events. nit: Reword: Defines whether desktop environments ...
4 years, 10 months ago (2016-02-05 21:39:26 UTC) #8
Sergey Ulanov
https://codereview.chromium.org/1673723002/diff/60001/remoting/host/ipc_desktop_environment.h File remoting/host/ipc_desktop_environment.h (right): https://codereview.chromium.org/1673723002/diff/60001/remoting/host/ipc_desktop_environment.h#newcode134 remoting/host/ipc_desktop_environment.h:134: // events. On 2016/02/05 21:39:26, joedow wrote: > nit: ...
4 years, 10 months ago (2016-02-05 21:51:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673723002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673723002/80001
4 years, 10 months ago (2016-02-05 21:53:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/170150)
4 years, 10 months ago (2016-02-05 22:25:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673723002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673723002/160001
4 years, 10 months ago (2016-02-13 01:33:37 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/179919)
4 years, 10 months ago (2016-02-13 01:51:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673723002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673723002/180001
4 years, 10 months ago (2016-02-15 05:33:15 UTC) #22
commit-bot: I haz the power
Committed patchset #9 (id:180001)
4 years, 10 months ago (2016-02-15 05:59:16 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:48:52 UTC) #26
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/85df3c48fd4a3be69b1a650cebc793024d4879b3
Cr-Commit-Position: refs/heads/master@{#375412}

Powered by Google App Engine
This is Rietveld 408576698