Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 173532: Add support for Mac NPAPI drawing model negotiation, along with a stub... (Closed)

Created:
11 years, 3 months ago by Amanda Walker
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, jam
Visibility:
Public.

Description

Add support for Mac NPAPI drawing model negotiation, along with a stub of Quickdraw model support (work in progress--QD plugins no longer crash, but they don't draw correctly either). Superseded by http://codereview.chromium.org/211031 Stuart: review John: FYI BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32097

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webkit/glue/plugins/plugin_host.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stuartmorgan
http://codereview.chromium.org/173532/diff/1/2 File webkit/glue/plugins/plugin_host.cc (right): http://codereview.chromium.org/173532/diff/1/2#newcode867 Line 867: plugin->set_drawing_model(model); Shouldn't this be outside the if, so ...
11 years, 3 months ago (2009-08-26 23:20:36 UTC) #1
Amanda Walker
New diffs with a change that didn't make it into 211031.
11 years, 1 month ago (2009-11-16 21:16:10 UTC) #2
stuartmorgan
11 years, 1 month ago (2009-11-16 21:21:13 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698