Remove the temporary Mac plugin whitelist....

Remove the temporary Mac plugin whitelist.
Support Mac NPAPI drawing and event model negotiation.  Implement a fallback
Quickdraw drawing model implementation so that old plugins don't crash.
This change does not address keyboard input issues (see issue 19194), just
display issues.
BUG=12030
TEST=Quickdraw based plugins (such as the QuickTime plugin) should not crash
when invoked, and may even display properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26724

[Amanda Walker, 2009-09-18 20:02:25]

Stuart: review
John: FYI

[stuartmorgan, 2009-09-18 20:50:50]

http://codereview.chromium.org/211031/diff/1/6
File webkit/glue/plugins/webplugin_delegate_impl.h (right):

http://codereview.chromium.org/211031/diff/1/6#newcode242
Line 242: GWorldPtr quickdraw_world_;
Why the qd_/quickdraw_ inconsistency?

http://codereview.chromium.org/211031/diff/1/3
File webkit/glue/plugins/webplugin_delegate_impl_mac.mm (right):

http://codereview.chromium.org/211031/diff/1/3#newcode109
Line 109: last_mouse_y_(0) {
Init for quickdraw_world_?

http://codereview.chromium.org/211031/diff/1/3#newcode177
Line 177: qd_port_.porty = 0;
These lines are redundant with the constructor, aren't they?

http://codereview.chromium.org/211031/diff/1/3#newcode187
Line 187: LOG(WARNING) << "NPAPI: unknown drawing model requested:" <<
instance_->drawing_model();
Maybe make this a NOTREACHED, since it would require this class and the plugin
negotiation logic to be out of sync, which would be bad news.

http://codereview.chromium.org/211031/diff/1/3#newcode362
Line 362: {
Maybe a comment here about why there's no paint event being sent in here, since
that's not apparent until later in the file.

http://codereview.chromium.org/211031/diff/1/3#newcode373
Line 373: BackColor(whiteColor);
Are these necessary for a bit blit?

[Amanda Walker, 2009-09-21 14:42:47]

On 2009/09/18 20:50:50, stuartmorgan wrote:
> Why the qd_/quickdraw_ inconsistency?

Fixed.

> Init for quickdraw_world_?

FIxed.

> These lines are redundant with the constructor, aren't they?

Yes, fixed.

> Maybe make this a NOTREACHED, since it would require this class and the plugin
> negotiation logic to be out of sync, which would be bad news.

Good idea.  Done.

> Maybe a comment here about why there's no paint event being sent in here,
since
> that's not apparent until later in the file.

Comment added.

> http://codereview.chromium.org/211031/diff/1/3#newcode373
> Line 373: BackColor(whiteColor);
> Are these necessary for a bit blit?

Usually yes (to avoid colorizing the image).

[stuartmorgan, 2009-09-21 18:13:00]

LGTM