Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1735203003: Fix: condition to hide generic file handlers has to be inverted. (Closed)

Created:
4 years, 10 months ago by kinaba
Modified:
4 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix: condition to hide generic file handlers has to be inverted. The previous code lists up all handlers when (!!hide == true) which is essentially when (hide == true). I believe it's not what's intended. BUG=none TEST=Install Evernote; "Open with" shows the app. TEST=Install Evernote; "Choose default" does not show the app. Committed: https://crrev.com/3c315ed174a6f52b8a4a6a58d029fd01c5b5737b Cr-Commit-Position: refs/heads/master@{#378049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
kinaba
PTAL
4 years, 10 months ago (2016-02-26 05:59:00 UTC) #3
kinaba
On 2016/02/26 05:59:00, kinaba wrote: > PTAL Looks like a regression from https://codereview.chromium.org/1378053004
4 years, 10 months ago (2016-02-26 06:05:00 UTC) #4
yawano
lgtm. Thank you!
4 years, 10 months ago (2016-02-27 00:38:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735203003/1
4 years, 10 months ago (2016-02-27 00:44:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 01:15:04 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 01:16:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c315ed174a6f52b8a4a6a58d029fd01c5b5737b
Cr-Commit-Position: refs/heads/master@{#378049}

Powered by Google App Engine
This is Rietveld 408576698