Simplify FileTasks in Files app.

Simplify FileTasks in Files app.

* Replaced tricky pending invocations logic with promises.
* Removed init().
* Moved entries and mimeTypes to the constructor.
* Removed unused methods and asserts.

BUG=None
TEST=Tested manually. All tests pass.

Committed: https://crrev.com/def5658e39a7217680c284988d4aa544d646b54d
Cr-Commit-Position: refs/heads/master@{#351961}

[mtomasz, 2015-10-01 06:13:25]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2015-10-01 06:13:33]

@hirono: PTAL. Thanks!

[mtomasz, 2015-10-01 06:14:13]

I forgot to fix tests. Doing it now.

[mtomasz, 2015-10-01 06:48:56]

@hirono: Fixed tests. PTAL. Thanks!

[hirono, 2015-10-01 07:31:47]

On 2015/10/01 06:48:56, mtomasz wrote:
> @hirono: Fixed tests. PTAL. Thanks!

Now FileTasks got to be much simpler. So how about completely remove async stuff
from FileTasks? Thanks to the past refactoring, I think we can do it for now.

1. Introduce FileTasks.create that returns Promise<!FileTasks>.
2. Use it in TaskController.

WDYT?

[mtomasz, 2015-10-01 09:27:13]

@hirono: Good idea. Done. PTAL, thanks!

[hirono, 2015-10-01 09:40:41]

Thanks! LGTM!

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:59: * @private
{!Array<!Object>}
We can mark it as @const.

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:64: * @private {Object}
ditto.

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:464: }.bind(this))
nit: You can pass both two functions to Promise#then. The difference is if
callback throws an exception, currently the callback is invoked doubly.

[mtomasz, 2015-10-02 01:09:09]

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:59: * @private
{!Array<!Object>}
On 2015/10/01 09:40:40, hirono wrote:
> We can mark it as @const.

Done.

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:64: * @private {Object}
On 2015/10/01 09:40:40, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/1378053004/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_tasks.js:464: }.bind(this))
On 2015/10/01 09:40:40, hirono wrote:
> nit: You can pass both two functions to Promise#then. The difference is if
> callback throws an exception, currently the callback is invoked doubly.

Done.

[mtomasz, 2015-10-02 04:49:22]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-10-02 04:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1378053004/#ps140001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-10-02 04:49:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378053004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378053004/140001

[commit-bot: I haz the power, 2015-10-02 05:16:24]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-10-02 05:18:31]

Patchset 8 (id:??) landed as
https://crrev.com/def5658e39a7217680c284988d4aa544d646b54d
Cr-Commit-Position: refs/heads/master@{#351961}