Issue 173516: Fix memory leak problem in PdfPsMetafile....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173516: Fix memory leak problem in PdfPsMetafile.... (Closed)

Created:
11 years, 4 months ago by myhuang

Modified:
9 years, 7 months ago

Reviewers:
tony, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix memory leak problem in PdfPsMetafile. The one committed in revision 24474 has a memory-leak problem. The cause is that we forgot to do CleanUpSurface(&page_surface_) near the end of PdfPsMetafile::FinishPage().

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -131 lines)			Patch
M	printing/pdf_ps_metafile_linux.h	View		5 chunks	+27 lines, -28 lines	0 comments	Download
M	printing/pdf_ps_metafile_linux.cc	View	1	6 chunks	+148 lines, -69 lines	1 comment	Download
M	printing/pdf_ps_metafile_linux_unittest.cc	View		4 chunks	+14 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

myhuang

http://codereview.chromium.org/173516/diff/1004/1007 File printing/pdf_ps_metafile_linux.cc (right): http://codereview.chromium.org/173516/diff/1004/1007#newcode284 Line 284: CleanUpSurface(&page_surface_); I forgot to do line#284 here in ...

11 years, 4 months ago (2009-08-26 20:50:36 UTC) #1

r24533

Expand Messages | Collapse Messages