Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 1734983004: After expanding <symbol> in <use>, expand its siblings (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

After expanding <symbol> in <use>, expand its siblings If the siblings are not expanded at this point, the loop of the children of the ancestor will lose the siblings because it's still referencing the old <symbol> element. This little loop fell out in https://codereview.chromium.org/272523002. BUG=589682 Committed: https://crrev.com/8c8aa6b2506795e72ea3ef7154b15e4abe0f4a6a Cr-Commit-Position: refs/heads/master@{#377922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, --1 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/use-nested-sibling-symbols.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/use-nested-sibling-symbols-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
fs
4 years, 10 months ago (2016-02-26 16:54:24 UTC) #2
pdr.
On 2016/02/26 at 16:54:24, fs wrote: > LGTM, this is the better approach.
4 years, 10 months ago (2016-02-26 18:00:01 UTC) #3
fs
On 2016/02/26 at 18:00:01, pdr wrote: > On 2016/02/26 at 16:54:24, fs wrote: > > ...
4 years, 10 months ago (2016-02-26 18:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734983004/1
4 years, 10 months ago (2016-02-26 18:05:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 18:14:46 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 18:15:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c8aa6b2506795e72ea3ef7154b15e4abe0f4a6a
Cr-Commit-Position: refs/heads/master@{#377922}

Powered by Google App Engine
This is Rietveld 408576698