Do not consider missing command as internal failure.

Do not consider missing command as internal failure.

If there is no command specified in the .isolated, which is because there was
none in the .isolate. It is in fact a user error, not an internal error. Report
this accordingly, so that the recipe do not ignore this error.

R=tandrii@chromium.org
BUG=

Committed: https://github.com/luci/luci-py/commit/7272431afa6028a3c5a4525a35dc316b88513b87

[M-A Ruel, 2016-02-24 18:37:42]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2016-02-24 18:39:56]

example task that would be shown as a user failure instead of internal failure:
https://omnibot-swarming-server.appspot.com/user/task/2d2a5457d649ae11

[Lei Lei, 2016-02-24 18:44:30]

On 2016/02/24 18:39:56, M-A Ruel wrote:
> example task that would be shown as a user failure instead of internal
failure:
> https://omnibot-swarming-server.appspot.com/user/task/2d2a5457d649ae11

This example test was triggered by me, I was testing isolate file for our
browser tests:(

[tandrii(chromium), 2016-02-24 18:45:59]

LGTM

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:199: '<The executable does not exist or a dependent
library is missing>\n'
does this "<" have a special meaning?

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:297: sys.stderr.write('<This occurs at the \'isolate\'
step\n')
missing '>' before \n

[M-A Ruel, 2016-02-24 19:03:14]

On 2016/02/24 18:44:30, Lei Lei wrote:
> This example test was triggered by me, I was testing isolate file for our
> browser tests:(

No problem. The fact it was reported as an internal error was a bug.

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:199: '<The executable does not exist or a dependent
library is missing>\n'
On 2016/02/24 18:45:59, tandrii(chromium) wrote:
> does this "<" have a special meaning?

No, I just wanted the output to look special.

https://codereview.chromium.org/1734743002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:297: sys.stderr.write('<This occurs at the \'isolate\'
step\n')
On 2016/02/24 18:45:59, tandrii(chromium) wrote:
> missing '>' before \n

Done.

[M-A Ruel, 2016-02-24 19:03:20]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2016-02-24 19:03:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1734743002/#ps40001
(title: "typo")

[commit-bot: I haz the power, 2016-02-24 19:03:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734743002/40001

[commit-bot: I haz the power, 2016-02-24 19:05:47]

Description was changed from

==========
Do not consider missing command as internal failure.

If there is no command specified in the .isolated, which is because there was
none in the .isolate. It is in fact a user error, not an internal error. Report
this accordingly, so that the recipe do not ignore this error.

R=tandrii@chromium.org
BUG=
==========

to

==========
Do not consider missing command as internal failure.

If there is no command specified in the .isolated, which is because there was
none in the .isolate. It is in fact a user error, not an internal error. Report
this accordingly, so that the recipe do not ignore this error.

R=tandrii@chromium.org
BUG=

Committed:
https://github.com/luci/luci-py/commit/7272431afa6028a3c5a4525a35dc316b88513b87
==========

[commit-bot: I haz the power, 2016-02-24 19:05:47]

Committed patchset #2 (id:40001) as
https://github.com/luci/luci-py/commit/7272431afa6028a3c5a4525a35dc316b88513b87