client/tests/run_isolated_smoke_test.py - Issue 1734743002: Do not consider missing command as internal failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/tests/run_isolated_smoke_test.py

Issue 1734743002: Do not consider missing command as internal failure. (Closed) Base URL: git@github.com:luci/luci-py.git@master

Patch Set: typo Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/tests/run_isolated_smoke_test.py

diff --git a/client/tests/run_isolated_smoke_test.py b/client/tests/run_isolated_smoke_test.py

index c96f010b7cdccb63782f33cf83e1923518bffebf..da06c889e138c0d36dcc5ee9b06bc7a83ee008a1 100755

--- a/client/tests/run_isolated_smoke_test.py

+++ b/client/tests/run_isolated_smoke_test.py

@@ -295,7 +295,10 @@ class RunIsolatedTest(unittest.TestCase):

expected = ['state.json', isolated_hash]

out, err, returncode = self._run(self._cmd_args(isolated_hash))

self.assertEqual('', out)

- self.assertIn('No command to run\n', err)

+ self.assertIn(

+ '<The .isolated doesn\'t declare any command to run!>\n'

+ '<Check your .isolate for missing \'command\' variable>\n',

+ err)

self.assertEqual(1, returncode)

actual = list_files_tree(self.cache)

self.assertEqual(sorted(expected), actual)

« no previous file with comments | « client/run_isolated.py ('k') | no next file » | no next file with comments »