Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1734293002: TEXTAREA should not reset the caret position when it is focused by sequential focus navigation. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TEXTAREA should not reset the caret position when it is focused by sequential focus navigation. We have reset it to the beginning of the TEXTAREA content. The new behavior matches to Firefox. IE resets it to the end of the content. BUG=5768 TEST=automated Committed: https://crrev.com/281b9124b31f6aa3c8030f06d25bef969c3964d5 Cr-Commit-Position: refs/heads/master@{#377824}

Patch Set 1 : #

Messages

Total messages: 10 (5 generated)
tkent
kochi@, would you review this please? Probably we should rename SelectionBehaviorOnFocus::Reset, or add another item ...
4 years, 10 months ago (2016-02-26 04:57:15 UTC) #4
kochi
lgtm Yeah, SelectionBehavior::Reset seems used elsewhere, adding another one specifically for sequential navigation would make ...
4 years, 10 months ago (2016-02-26 05:43:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734293002/20001
4 years, 10 months ago (2016-02-26 05:57:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-26 06:04:27 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 06:05:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/281b9124b31f6aa3c8030f06d25bef969c3964d5
Cr-Commit-Position: refs/heads/master@{#377824}

Powered by Google App Engine
This is Rietveld 408576698