Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1734293002: TEXTAREA should not reset the caret position when it is focused by sequential focus navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/forms/focus-selection-textarea-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
index e0c03a30f01e754123cf24fa9c89fee5b8b98fd9..d24b6edec88675d7d30c7f315bd8551d9e40b4f6 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
@@ -243,9 +243,7 @@ bool HTMLTextAreaElement::shouldShowFocusRingOnMouseFocus() const
void HTMLTextAreaElement::updateFocusAppearance(SelectionBehaviorOnFocus selectionBehavior)
{
switch (selectionBehavior) {
- case SelectionBehaviorOnFocus::Reset:
- setSelectionRange(0, 0, SelectionHasNoDirection, NotDispatchSelectEvent);
- break;
+ case SelectionBehaviorOnFocus::Reset: // Fallthrough.
case SelectionBehaviorOnFocus::Restore:
restoreCachedSelection();
break;
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/forms/focus-selection-textarea-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698