Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734243004: Remove strong mode support from materialized literals. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from materialized literals. R=bmeurer@chromium.org BUG=v8:3956 LOG=n Committed: https://crrev.com/239ed8ffa885a4abb87bfc11d37ddd78d05eff87 Cr-Commit-Position: refs/heads/master@{#34333}

Patch Set 1 #

Patch Set 2 : Fix missed calls. #

Patch Set 3 : Test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -151 lines) Patch
M src/ast/ast.h View 11 chunks +16 lines, -32 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/preparser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 13 chunks +21 lines, -34 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D test/message/strong-object-freeze-prop.js View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D test/message/strong-object-freeze-prop.out View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D test/message/strong-object-set-proto.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D test/message/strong-object-set-proto.out View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1731063007 Patch 1

Messages

Total messages: 16 (7 generated)
Michael Starzinger
Benedikt: PTAL. Andreas: FYI.
4 years, 10 months ago (2016-02-26 10:25:51 UTC) #2
Benedikt Meurer
Very nice. LGTM.
4 years, 10 months ago (2016-02-26 10:29:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734243004/40001
4 years, 10 months ago (2016-02-26 14:02:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11575)
4 years, 10 months ago (2016-02-26 14:08:43 UTC) #8
Michael Starzinger
Dan/Adam/Andreas: Need parser approval. Feel free to CQ if you want.
4 years, 10 months ago (2016-02-26 14:30:02 UTC) #10
adamk
lgtm
4 years, 10 months ago (2016-02-26 17:42:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734243004/40001
4 years, 10 months ago (2016-02-26 17:42:51 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 17:44:40 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 17:45:09 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/239ed8ffa885a4abb87bfc11d37ddd78d05eff87
Cr-Commit-Position: refs/heads/master@{#34333}

Powered by Google App Engine
This is Rietveld 408576698