Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1731063007: Remove the global Strength enum class completely. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_strong-remove-literals
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the global Strength enum class completely. R=bmeurer@chromium.org BUG=v8:3956 LOG=n Committed: https://crrev.com/00e9447ad3e230036ddc4a9701a348778ebe8e17 Cr-Commit-Position: refs/heads/master@{#34398}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Remove Map::is_strong. #

Patch Set 4 : Adapt test expectation. #

Patch Set 5 : Fix think'o. #

Patch Set 6 : Remove more cruft. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -277 lines) Patch
M src/ast/ast.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 10 chunks +0 lines, -50 lines 0 comments Download
M src/contexts.h View 1 2 4 chunks +6 lines, -32 lines 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 2 3 chunks +2 lines, -8 lines 0 comments Download
M src/factory.cc View 1 2 5 chunks +9 lines, -23 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -29 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/js/macros.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/js/v8natives.js View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 4 12 chunks +11 lines, -45 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects-printer.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 2 3 4 5 2 chunks +0 lines, -14 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Starzinger
Benedikt: PTAL. Andreas: FYI.
4 years, 10 months ago (2016-02-26 13:51:17 UTC) #2
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-26 14:04:06 UTC) #3
rossberg
lgtm
4 years, 9 months ago (2016-02-29 16:39:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731063007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731063007/100001
4 years, 9 months ago (2016-03-01 15:54:04 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-01 16:05:47 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 16:06:13 UTC) #10
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/00e9447ad3e230036ddc4a9701a348778ebe8e17
Cr-Commit-Position: refs/heads/master@{#34398}

Powered by Google App Engine
This is Rietveld 408576698