Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734223004: Make TypedArray.from and TypedArray.of writable and configurable (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make TypedArray.from and TypedArray.of writable and configurable BUG=v8:4315 R=adamk LOG=Y Committed: https://crrev.com/60eb0fdf612eef3fc3a9ce2da852a926bdc83a71 Cr-Commit-Position: refs/heads/master@{#34310}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/js/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-of.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223004/1
4 years, 10 months ago (2016-02-26 02:42:56 UTC) #2
Dan Ehrenberg
4 years, 10 months ago (2016-02-26 02:43:05 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14291)
4 years, 10 months ago (2016-02-26 02:54:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223004/20001
4 years, 10 months ago (2016-02-26 03:02:37 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 03:26:01 UTC) #9
adamk
lgtm Weird that these ended up this way.
4 years, 10 months ago (2016-02-26 04:30:18 UTC) #10
Dan Ehrenberg
I think it's because we copied a test from Mozilla that enforced it.
4 years, 10 months ago (2016-02-26 04:38:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223004/20001
4 years, 10 months ago (2016-02-26 04:38:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 04:39:48 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 04:40:03 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/60eb0fdf612eef3fc3a9ce2da852a926bdc83a71
Cr-Commit-Position: refs/heads/master@{#34310}

Powered by Google App Engine
This is Rietveld 408576698