src/js/typedarray.js - Issue 1734223004: Make TypedArray.from and TypedArray.of writable and configurable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/typedarray.js

Issue 1734223004: Make TypedArray.from and TypedArray.of writable and configurable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/typedarray.js

diff --git a/src/js/typedarray.js b/src/js/typedarray.js

index 3d500a379ec8786d324600b6c9a77b8f54199b61..359f48435a7f6bbaf29d28a34268b7995742deaf 100644

--- a/src/js/typedarray.js

+++ b/src/js/typedarray.js

@@ -785,7 +785,7 @@ function TypedArray() {

%FunctionSetPrototype(TypedArray, new GlobalObject());

%AddNamedProperty(TypedArray.prototype,

"constructor", TypedArray, DONT_ENUM);

-utils.InstallFunctions(TypedArray, DONT_ENUM | DONT_DELETE | READ_ONLY, [

+utils.InstallFunctions(TypedArray, DONT_ENUM, [

"from", TypedArrayFrom,

"of", TypedArrayOf

]);

« no previous file with comments | « no previous file | test/mjsunit/es6/typedarray-of.js » ('j') | no next file with comments »