Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: src/gpu/GrPipeline.cpp

Issue 1734163002: Replace fWillReadFragmentPosition with a bitfield (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrPipeline.cpp
diff --git a/src/gpu/GrPipeline.cpp b/src/gpu/GrPipeline.cpp
index e1c733a676114dd559795fcaee1eb7b19181221e..10905d003e22e9f9d9e606511fae71b957d72a5e 100644
--- a/src/gpu/GrPipeline.cpp
+++ b/src/gpu/GrPipeline.cpp
@@ -184,23 +184,19 @@ void GrPipeline::adjustProgramFromOptimizations(const GrPipelineBuilder& pipelin
int* firstColorProcessorIdx,
int* firstCoverageProcessorIdx) {
fIgnoresCoverage = SkToBool(flags & GrXferProcessor::kIgnoreCoverage_OptFlag);
- fReadsFragPosition = this->getXferProcessor().willReadFragmentPosition();
+ fBuiltInState = GrProcessor::kNone_BuiltInState;
Chris Dalton 2016/02/25 20:38:37 We a problem here that fBuiltInState *should* inti
joshualitt 2016/02/25 20:50:27 That should be okay. We never remove the primitiv
Chris Dalton 2016/02/25 20:57:46 But the primitive processor might not exist yet, r
joshualitt 2016/02/25 21:00:50 right, but that should be okay because when we go
Chris Dalton 2016/02/25 22:24:24 I removed info about the fragment position from th
if ((flags & GrXferProcessor::kIgnoreColor_OptFlag) ||
(flags & GrXferProcessor::kOverrideColor_OptFlag)) {
*firstColorProcessorIdx = pipelineBuilder.numColorFragmentProcessors();
} else {
- if (colorPOI.readsFragPosition()) {
- fReadsFragPosition = true;
- }
+ fBuiltInState |= colorPOI.builtInState();
}
if (flags & GrXferProcessor::kIgnoreCoverage_OptFlag) {
*firstCoverageProcessorIdx = pipelineBuilder.numCoverageFragmentProcessors();
} else {
- if (coveragePOI.readsFragPosition()) {
- fReadsFragPosition = true;
- }
+ fBuiltInState |= coveragePOI.builtInState();
}
}

Powered by Google App Engine
This is Rietveld 408576698