Replace fWillReadFragmentPosition with a bitfield

src/gpu/GrPipeline.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrPipeline.h"
 
 #include "GrCaps.h"
@@ skipping 166 matching lines @@
     }
 }
 
 void GrPipeline::adjustProgramFromOptimizations(const GrPipelineBuilder& pipelineBuilder,
                                                 GrXferProcessor::OptFlags flags,
                                                 const GrProcOptInfo& colorPOI,
                                                 const GrProcOptInfo& coveragePOI,
                                                 int* firstColorProcessorIdx,
                                                 int* firstCoverageProcessorIdx) {
     fIgnoresCoverage = SkToBool(flags & GrXferProcessor::kIgnoreCoverage_OptFlag);
-    fReadsFragPosition = this->getXferProcessor().willReadFragmentPosition();
+    fBuiltInState = GrProcessor::kNone_BuiltInState;

[Chris Dalton, 2016/02/25 20:38:37]

We a problem here that fBuiltInState *should* intitialize with:

 fBuiltInState = GrPrimitiveProcessor.builtInState();

But I don't think the primitive processor is known yet at this point. Thoughts?
Otherwise if the primitive processor enables built in state, the pipeline won't
know about it.

[joshualitt, 2016/02/25 20:50:27]

That should be okay.  We never remove the primitive processor, and it will
always get a chance to modify the key / insert whatever code it wants. 

[Chris Dalton, 2016/02/25 20:57:46]

But the primitive processor might not exist yet, right?

[joshualitt, 2016/02/25 21:00:50]

right, but that should be okay because when we go to flush the draw we'll have a
GrPrimitiveProcessor + GrPipeline combination and at that point the
GrPrimitiveProcessor can do whatever it wants, regardless of the builtinstate
values on the GrPipeline.

[Chris Dalton, 2016/02/25 22:24:24]

I removed info about the fragment position from this class and from GrPocOptInfo
as we decided offline. (It didn't really belong in this class or GrProcOptInfo
anyway.)

 
     if ((flags & GrXferProcessor::kIgnoreColor_OptFlag) ||
         (flags & GrXferProcessor::kOverrideColor_OptFlag)) {
         *firstColorProcessorIdx = pipelineBuilder.numColorFragmentProcessors();
     } else {
-        if (colorPOI.readsFragPosition()) {
-            fReadsFragPosition = true;
-        }
+        fBuiltInState |= colorPOI.builtInState();
     }
 
     if (flags & GrXferProcessor::kIgnoreCoverage_OptFlag) {
         *firstCoverageProcessorIdx = pipelineBuilder.numCoverageFragmentProcessors();
     } else {
-        if (coveragePOI.readsFragPosition()) {
-            fReadsFragPosition = true;
-        }
+        fBuiltInState |= coveragePOI.builtInState();
     }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 bool GrPipeline::AreEqual(const GrPipeline& a, const GrPipeline& b,
                           bool ignoreCoordTransforms) {
     SkASSERT(&a != &b);
 
     if (a.getRenderTarget() != b.getRenderTarget() ||
@@ skipping 14 matching lines @@
     }
 
     for (int i = 0; i < a.numFragmentProcessors(); i++) {
         if (!a.getFragmentProcessor(i).isEqual(b.getFragmentProcessor(i), ignoreCoordTransforms)) {
             return false;
         }
     }
     return true;
 }