Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h

Issue 1734063003: Share animations from compositor to main thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make NotifyAnimationTakeover pure virtual Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h
diff --git a/third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h b/third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h
index 58339f8069ee70f936f3357941daf346d0c65c87..dd961dc501ad3d5b1b85c793570a87623a25e099 100644
--- a/third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h
+++ b/third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h
@@ -6,6 +6,7 @@
#define WebCompositorAnimationDelegate_h
#include "WebCommon.h"
+#include "cc/animation/animation_curve.h"
namespace blink {
@@ -16,6 +17,11 @@ public:
virtual void notifyAnimationStarted(double monotonicTime, int group) = 0;
virtual void notifyAnimationFinished(double monotonicTime, int group) = 0;
virtual void notifyAnimationAborted(double monotonicTime, int group) = 0;
+ // TODO(ymalik): Make pure virtual.
ymalik 2016/02/26 19:05:25 I tried to make this pure virtual, but had the fol
ajuma 2016/02/26 23:56:54 No, core isn't allowed to refer to cc types. The o
ymalik 2016/02/29 16:31:09 Acknowledged.
Rick Byers 2016/02/29 20:21:35 I think a regular virtual is probably OK if you ca
+ virtual void notifyAnimationTakeover(
+ double monotonicTime,
+ double animationStartTime,
+ scoped_ptr<cc::AnimationCurve> curve) { }
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698