Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h

Issue 1734063003: Share animations from compositor to main thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make NotifyAnimationTakeover pure virtual Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebCompositorAnimationDelegate_h 5 #ifndef WebCompositorAnimationDelegate_h
6 #define WebCompositorAnimationDelegate_h 6 #define WebCompositorAnimationDelegate_h
7 7
8 #include "WebCommon.h" 8 #include "WebCommon.h"
9 #include "cc/animation/animation_curve.h"
9 10
10 namespace blink { 11 namespace blink {
11 12
12 class BLINK_PLATFORM_EXPORT WebCompositorAnimationDelegate { 13 class BLINK_PLATFORM_EXPORT WebCompositorAnimationDelegate {
13 public: 14 public:
14 virtual ~WebCompositorAnimationDelegate() { } 15 virtual ~WebCompositorAnimationDelegate() { }
15 16
16 virtual void notifyAnimationStarted(double monotonicTime, int group) = 0; 17 virtual void notifyAnimationStarted(double monotonicTime, int group) = 0;
17 virtual void notifyAnimationFinished(double monotonicTime, int group) = 0; 18 virtual void notifyAnimationFinished(double monotonicTime, int group) = 0;
18 virtual void notifyAnimationAborted(double monotonicTime, int group) = 0; 19 virtual void notifyAnimationAborted(double monotonicTime, int group) = 0;
20 // TODO(ymalik): Make pure virtual.
ymalik 2016/02/26 19:05:25 I tried to make this pure virtual, but had the fol
ajuma 2016/02/26 23:56:54 No, core isn't allowed to refer to cc types. The o
ymalik 2016/02/29 16:31:09 Acknowledged.
Rick Byers 2016/02/29 20:21:35 I think a regular virtual is probably OK if you ca
21 virtual void notifyAnimationTakeover(
22 double monotonicTime,
23 double animationStartTime,
24 scoped_ptr<cc::AnimationCurve> curve) { }
19 }; 25 };
20 26
21 } // namespace blink 27 } // namespace blink
22 28
23 #endif // WebCompositorAnimationDelegate_h 29 #endif // WebCompositorAnimationDelegate_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698