Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734043002: Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ ) Reason for revert: Need workaround for chrome to build Original issue's description: > Move Budgeted enum out of SkSurface, use in GrTextureProvider > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005 > DOCS_PREVIEW= https://skia.org/?cl=1728093005 > > Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/bd500f09ce5b1ca464431d693f9ec5da60a59230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -222 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cmake/example.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M experimental/fiddle/fiddle_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bleed.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/discard.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/image.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/image_pict.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/image_shader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagetoyuvplanes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/surface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkSurface.h View 4 chunks +18 lines, -6 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +0 lines, -11 lines 0 comments Download
M include/gpu/GrTextureProvider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M site/user/api/canvas.md View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuResourcePriv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/SkGr.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 7 chunks +12 lines, -9 lines 0 comments Download
M src/image/SkSurface.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkSurface_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/utils/SkImageGeneratorUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CopySurfaceTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/EGLImageTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/FloatingPointTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 10 chunks +12 lines, -13 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/SpecialImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 5 chunks +16 lines, -12 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TextureStorageAllocator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/VisualBench/WrappedBenchmark.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/kilobench/kilobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider
4 years, 10 months ago (2016-02-25 14:51:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734043002/1
4 years, 10 months ago (2016-02-25 14:51:47 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 14:52:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd500f09ce5b1ca464431d693f9ec5da60a59230

Powered by Google App Engine
This is Rietveld 408576698