Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1733973004: Limit Public-Key-Pins max-age to 60 days (Closed)

Created:
4 years, 10 months ago by elawrence
Modified:
4 years, 9 months ago
Reviewers:
Ryan Sleevi, estark
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit Public-Key-Pins max-age to 60 days Set the maximum validity period for a Public-Key-Pins header to 60 days as suggested by http://tools.ietf.org/html/rfc7469#section-4.1 BUG=523654 TEST=net_unittests Committed: https://crrev.com/a6c42bddb0ce6253b7da6f3b66460a243071d04f Cr-Commit-Position: refs/heads/master@{#378231}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M net/http/http_security_headers.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_security_headers.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
elawrence
4 years, 10 months ago (2016-02-25 21:01:23 UTC) #2
estark
Thanks, this is looking good! I'll do a first pass review over this, and after ...
4 years, 10 months ago (2016-02-25 21:58:04 UTC) #3
elawrence
> this change will cause some existing unit tests to fail Tests updated > Was ...
4 years, 9 months ago (2016-02-26 17:57:55 UTC) #6
estark
Thanks, lgtm. Now you'll need an OWNER to review; probably rsleevi@ or davidben@ are the ...
4 years, 9 months ago (2016-02-26 22:02:40 UTC) #7
elawrence
Ryan-- can you please review as an OWNER in this area. Thanks!
4 years, 9 months ago (2016-02-26 22:16:29 UTC) #9
Ryan Sleevi
lgtm
4 years, 9 months ago (2016-02-26 22:57:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733973004/20001
4 years, 9 months ago (2016-02-29 16:45:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 18:00:50 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 18:03:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6c42bddb0ce6253b7da6f3b66460a243071d04f
Cr-Commit-Position: refs/heads/master@{#378231}

Powered by Google App Engine
This is Rietveld 408576698