Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17335008: remove dst/rendertarget support for kARGB_4444_Config (Closed)

Created:
7 years, 6 months ago by reed1
Modified:
7 years, 6 months ago
Reviewers:
djsollen, scroggo, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove dst/rendertarget support for kARGB_4444_Config BUG= Committed: https://code.google.com/p/skia/source/detail?r=9727

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1203 lines) Patch
M bench/BitmapBench.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/tilemodes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkBlitRow.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkXfermode.h View 2 chunks +0 lines, -4 lines 0 comments Download
M include/effects/SkAvoidXfermode.h View 1 chunk +0 lines, -2 lines 0 comments Download
D samplecode/SampleStrokeText.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M src/core/SkBlitRow_D16.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
D src/core/SkBlitRow_D4444.cpp View 1 chunk +0 lines, -218 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D src/core/SkBlitter_4444.cpp View 1 chunk +0 lines, -480 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -14 lines 2 comments Download
M src/core/SkCoreBlitters.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +0 lines, -54 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 2 chunks +0 lines, -53 lines 0 comments Download
M src/effects/SkTransparentShader.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D src/utils/mac/SkBitmap_Mac.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
M tests/ARGBImageEncoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/BitmapGetColorTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/BitmapHasherTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 1 2 chunks +1 line, -2 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
reed1
... assuming we want to do this at all
7 years, 6 months ago (2013-06-19 16:03:35 UTC) #1
bsalomon
You missed some :) https://code.google.com/p/chromium/codesearch#search/&q=4444_Gr&sq=package:chromium&type=cs https://codereview.chromium.org/17335008/diff/1/tests/GpuBitmapCopyTest.cpp File tests/GpuBitmapCopyTest.cpp (right): https://codereview.chromium.org/17335008/diff/1/tests/GpuBitmapCopyTest.cpp#newcode122 tests/GpuBitmapCopyTest.cpp:122: { SkBitmap::kRGB_565_Config, "011" }, ...
7 years, 6 months ago (2013-06-20 08:28:55 UTC) #2
djsollen
I'm good with removing 4444 support, but I haven't had the time to review this ...
7 years, 6 months ago (2013-06-20 09:05:24 UTC) #3
reed1
https://codereview.chromium.org/17335008/diff/1/tests/GpuBitmapCopyTest.cpp File tests/GpuBitmapCopyTest.cpp (right): https://codereview.chromium.org/17335008/diff/1/tests/GpuBitmapCopyTest.cpp#newcode122 tests/GpuBitmapCopyTest.cpp:122: { SkBitmap::kRGB_565_Config, "011" }, On 2013/06/20 08:28:55, bsalomon wrote: ...
7 years, 6 months ago (2013-06-21 17:44:07 UTC) #4
reed1
Committed patchset #2 manually as r9727 (presubmit successful).
7 years, 6 months ago (2013-06-21 18:31:08 UTC) #5
scroggo
https://codereview.chromium.org/17335008/diff/6001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/17335008/diff/6001/src/core/SkCanvas.cpp#newcode464 src/core/SkCanvas.cpp:464: class AutoValidator { It appears this entire class can ...
7 years, 6 months ago (2013-06-21 18:56:59 UTC) #6
reed1
7 years, 6 months ago (2013-06-21 19:06:29 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/17335008/diff/6001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/17335008/diff/6001/src/core/SkCanvas.cpp#newc...
src/core/SkCanvas.cpp:464: class AutoValidator {
On 2013/06/21 18:56:59, scroggo wrote:
> It appears this entire class can be removed - I don't see any references to
it,
> and it's in a cpp file.

Done.

https://codereview.chromium.org/17335008/diff/6001/tests/GpuBitmapCopyTest.cpp
File tests/GpuBitmapCopyTest.cpp (right):

https://codereview.chromium.org/17335008/diff/6001/tests/GpuBitmapCopyTest.cp...
tests/GpuBitmapCopyTest.cpp:121: { SkBitmap::kNo_Config,         "000"  },
On 2013/06/21 18:56:59, scroggo wrote:
> These should now be "00" and "01", respectively.

Done.

Powered by Google App Engine
This is Rietveld 408576698