Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: tests/WArrayTest.cpp

Issue 1733113002: Unit Tests: eliminate stray SkDebugf()s. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/Time.cpp ('k') | tests/YUVTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/WArrayTest.cpp
diff --git a/tests/WArrayTest.cpp b/tests/WArrayTest.cpp
index 48be9526371d6424f348caa988edfd9d58b0918c..40128fa2b4dd47c1e62c1a5dc5f0d8ce606928bf 100644
--- a/tests/WArrayTest.cpp
+++ b/tests/WArrayTest.cpp
@@ -141,7 +141,7 @@ class TestWData {
, fSubset(subset)
, fSubsetLen(subsetLen)
, fExpected(expected) {
- REPORTER_ASSERT(reporter, RunTest());
+ this->runTest(reporter);
}
private:
@@ -160,16 +160,14 @@ class TestWData {
return false;
}
- bool RunTest() {
+ void runTest(skiatest::Reporter* reporter) {
SkAutoTDelete<SkAdvancedTypefaceMetrics::AdvanceMetric<int16_t> > result;
result.reset(getAdvanceData((void*)this, fAdvancesLen, fSubset, fSubsetLen, getAdvance));
SkString stringResult = stringify_advance_data(result);
if (!stringResult.equals(fExpected)) {
- SkDebugf("Expected: %s\n Result: %s\n", fExpected, stringResult.c_str());
- return false;
+ ERRORF(reporter, "Expected: %s\n Result: %s\n", fExpected, stringResult.c_str());
}
- return true;
}
};
« no previous file with comments | « tests/Time.cpp ('k') | tests/YUVTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698