Unit Tests: eliminate stray SkDebugf()s.

tests/WArrayTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Test.h"
 
 // Include the implementation so we can make an appropriate template instance.
@@ skipping 123 matching lines @@
   public:
     TestWData(skiatest::Reporter* reporter,
               const int16_t advances[], int advanceLen,
               const uint32_t subset[], int subsetLen,
               const char* expected)
             : fAdvances(advances)
             , fAdvancesLen(advanceLen)
             , fSubset(subset)
             , fSubsetLen(subsetLen)
             , fExpected(expected) {
-        REPORTER_ASSERT(reporter, RunTest());
+        this->runTest(reporter);
     }
 
   private:
     const int16_t* fAdvances;
     const int fAdvancesLen;
     const uint32_t* fSubset;
     const int fSubsetLen;
     const char* fExpected;
 
     static bool getAdvance(void* tc, int gId, int16_t* advance) {
         TestWData* testCase = (TestWData*)tc;
         if (gId >= 0 && gId < testCase->fAdvancesLen) {
             *advance = testCase->fAdvances[gId];
             return true;
         }
         return false;
     }
 
-    bool RunTest() {
+    void runTest(skiatest::Reporter* reporter) {
         SkAutoTDelete<SkAdvancedTypefaceMetrics::AdvanceMetric<int16_t> > result;
         result.reset(getAdvanceData((void*)this, fAdvancesLen, fSubset, fSubsetLen, getAdvance));
 
         SkString stringResult = stringify_advance_data(result);
         if (!stringResult.equals(fExpected)) {
-            SkDebugf("Expected: %s\n  Result: %s\n", fExpected, stringResult.c_str());
-            return false;
+            ERRORF(reporter, "Expected: %s\n  Result: %s\n", fExpected, stringResult.c_str());
         }
-        return true;
     }
 };
 
 DEF_TEST(WArray, reporter) {
     TestWData(reporter, data1, SK_ARRAY_COUNT(data1), nullptr, 0, expected1);
     TestWData(reporter, data2, SK_ARRAY_COUNT(data2), nullptr, 0, expected2);
     TestWData(reporter, data3, SK_ARRAY_COUNT(data3), nullptr, 0, expected3);
     TestWData(reporter, data4, SK_ARRAY_COUNT(data4), nullptr, 0, expected4);
     TestWData(reporter, data5, SK_ARRAY_COUNT(data5), nullptr, 0, expected5);
     TestWData(reporter, data6, SK_ARRAY_COUNT(data6), nullptr, 0, expected6);
@@ skipping 15 matching lines @@
     TestWData(reporter, data12, SK_ARRAY_COUNT(data12), nullptr, 0, expected12);
     TestWData(reporter, data12, SK_ARRAY_COUNT(data12), subset12,
               SK_ARRAY_COUNT(subset12), expectedSubset12);
     TestWData(reporter, data13, SK_ARRAY_COUNT(data13), nullptr, 0, expected13);
     TestWData(reporter, data13, SK_ARRAY_COUNT(data13), subset13,
               SK_ARRAY_COUNT(subset13), expectedSubset13);
     TestWData(reporter, data14, SK_ARRAY_COUNT(data14), nullptr, 0, expected14);
     TestWData(reporter, data14, SK_ARRAY_COUNT(data14), subset14,
               SK_ARRAY_COUNT(subset14), expectedSubset14);
 }