Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2295)

Unified Diff: tests/SerializationTest.cpp

Issue 1733113002: Unit Tests: eliminate stray SkDebugf()s. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/PDFJpegEmbedTest.cpp ('k') | tests/SrcOverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SerializationTest.cpp
diff --git a/tests/SerializationTest.cpp b/tests/SerializationTest.cpp
index ba95ddf8da25f56a33bf3d5175605aa413d0fe4a..a4e40c54eec6da109f28295908989d6a943eab99 100644
--- a/tests/SerializationTest.cpp
+++ b/tests/SerializationTest.cpp
@@ -357,7 +357,7 @@ static void TestPictureTypefaceSerialization(skiatest::Reporter* reporter) {
SkString filename = GetResourcePath("/fonts/test.ttc");
SkAutoTUnref<SkTypeface> typeface(SkTypeface::CreateFromFile(filename.c_str(), 1));
if (!typeface) {
- SkDebugf("Could not run fontstream test because test.ttc not found.");
+ INFOF(reporter, "Could not run fontstream test because test.ttc not found.");
} else {
serialize_and_compare_typeface(typeface, "A!", reporter);
}
@@ -367,13 +367,13 @@ static void TestPictureTypefaceSerialization(skiatest::Reporter* reporter) {
// Load typeface as stream to create with axis settings.
SkAutoTDelete<SkStreamAsset> distortable(GetResourceAsStream("/fonts/Distortable.ttf"));
if (!distortable) {
- SkDebugf("Could not run fontstream test because Distortable.ttf not found.");
+ INFOF(reporter, "Could not run fontstream test because Distortable.ttf not found.");
} else {
SkFixed axis = SK_FixedSqrt2;
SkAutoTUnref<SkTypeface> typeface(SkTypeface::CreateFromFontData(
new SkFontData(distortable.detach(), 0, &axis, 1)));
if (!typeface) {
- SkDebugf("Could not run fontstream test because Distortable.ttf not created.");
+ INFOF(reporter, "Could not run fontstream test because Distortable.ttf not created.");
} else {
serialize_and_compare_typeface(typeface, "abc", reporter);
}
« no previous file with comments | « tests/PDFJpegEmbedTest.cpp ('k') | tests/SrcOverTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698