Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: tests/PDFJpegEmbedTest.cpp

Issue 1733113002: Unit Tests: eliminate stray SkDebugf()s. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/MemsetTest.cpp ('k') | tests/SerializationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PDFJpegEmbedTest.cpp
diff --git a/tests/PDFJpegEmbedTest.cpp b/tests/PDFJpegEmbedTest.cpp
index 5185eb7bd4169efa97fe1772d2dd87c0a081856b..9d83fe6757e1068434bb48dd041e7148ecd65402 100644
--- a/tests/PDFJpegEmbedTest.cpp
+++ b/tests/PDFJpegEmbedTest.cpp
@@ -42,9 +42,9 @@ static SkData* load_resource(
skiatest::Reporter* r, const char* test, const char* filename) {
SkString path(GetResourcePath(filename));
SkData* data = SkData::NewFromFileName(path.c_str());
- if (!data && r->verbose()) {
- SkDebugf("\n%s: Resource '%s' can not be found.\n",
- test, filename);
+ if (!data) {
+ INFOF(r, "\n%s: Resource '%s' can not be found.\n",
+ test, filename);
}
return data; // May return nullptr.
}
@@ -143,9 +143,7 @@ DEF_TEST(JpegIdentification, r) {
ERRORF(r, "%s failed jfif type test", kTests[i].path);
continue;
}
- if (r->verbose()) {
- SkDebugf("\nJpegIdentification: %s [%d x %d]\n", kTests[i].path,
- info.fSize.width(), info.fSize.height());
- }
+ INFOF(r, "\nJpegIdentification: %s [%d x %d]\n", kTests[i].path,
+ info.fSize.width(), info.fSize.height());
}
}
« no previous file with comments | « tests/MemsetTest.cpp ('k') | tests/SerializationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698