Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1732923002: Revert of Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D. (Closed)

Created:
4 years, 10 months ago by engedy
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews, ajuma+watch-canvas_chromium.org, Rik, dshwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D. (patchset #6 id:100001 of https://codereview.chromium.org/1710633002/ ) Reason for revert: Speculative revert to fix WebKit Win non-Oilpan (dbg) breakage. Original issue's description: > Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D. > > This will allow an additional sub-class of BaseRC2D called PaintRC2D. > BaseRC2D contains the subset of APIs needed for PaintRC2D. > > See: https://drafts.css-houdini.org/css-paint-api/#paintrenderingcontext2d > > BUG=578252 > > Committed: https://crrev.com/4333ef80f90f702a0571c030f15f0e317931ee7d > Cr-Commit-Position: refs/heads/master@{#377082} TBR=junov@chromium.org,sigbjornf@opera.com,ikilpatrick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true BUG=578252 Committed: https://crrev.com/5f9ff30aae3b19c25c14480ff0fbe291bf71a27d Cr-Commit-Position: refs/heads/master@{#377348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1553 lines, -1747 lines) Patch
D third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 chunk +0 lines, -291 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +0 lines, -1366 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 6 chunks +140 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 13 chunks +1413 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
engedy
Created Revert of Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D.
4 years, 10 months ago (2016-02-24 16:09:39 UTC) #1
engedy
Pushing through try jobs to make sure no dependent patches have landed in the meantime.
4 years, 10 months ago (2016-02-24 16:10:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732923002/1
4 years, 10 months ago (2016-02-24 16:10:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 19:43:07 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 19:44:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f9ff30aae3b19c25c14480ff0fbe291bf71a27d
Cr-Commit-Position: refs/heads/master@{#377348}

Powered by Google App Engine
This is Rietveld 408576698