Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2462)

Unified Diff: chrome/browser/profiles/profile_browsertest.cc

Issue 1732493002: Prevent URLFetcher::AppendChunkedData from dereferencing NULL pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_browsertest.cc
diff --git a/chrome/browser/profiles/profile_browsertest.cc b/chrome/browser/profiles/profile_browsertest.cc
index 6092d046d408b79ce0fcb6d3e28588d7012ea24e..bc158400776d0e3eb52e52834378fff2a5cc1988 100644
--- a/chrome/browser/profiles/profile_browsertest.cc
+++ b/chrome/browser/profiles/profile_browsertest.cc
@@ -527,12 +527,6 @@ IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
browser()->profile()->GetMediaRequestContext());
}
-IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
eroman 2016/03/26 00:55:16 Why the removals?
mmenke 2016/03/28 17:33:11 git meltdown...These are from another CL...Grr. R
- URLFetcherUsingExtensionContextDuringShutdown) {
- StartActiveFetcherDuringProfileShutdownTest(
- browser()->profile()->GetRequestContextForExtensions());
-}
-
// The following tests make sure that it's safe to destroy an incognito profile
// while one of the its URLRequestContextGetters is in use by a URLFetcher.
@@ -543,13 +537,3 @@ IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
RunURLFetcherActiveDuringIncognitoTeardownTest(
incognito_browser, incognito_browser->profile()->GetRequestContext());
}
-
-IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
- URLFetcherUsingExtensionContextDuringIncognitoTeardown) {
- Browser* incognito_browser =
- OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));
-
- RunURLFetcherActiveDuringIncognitoTeardownTest(
- incognito_browser,
- incognito_browser->profile()->GetRequestContextForExtensions());
-}
« no previous file with comments | « no previous file | components/cronet/android/url_request_adapter.h » ('j') | net/base/chunked_upload_data_stream.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698