Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/profiles/profile_browsertest.cc

Issue 1732493002: Prevent URLFetcher::AppendChunkedData from dereferencing NULL pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile.h" 5 #include "chrome/browser/profiles/profile.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 StartActiveFetcherDuringProfileShutdownTest( 520 StartActiveFetcherDuringProfileShutdownTest(
521 browser()->profile()->GetRequestContext()); 521 browser()->profile()->GetRequestContext());
522 } 522 }
523 523
524 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, 524 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
525 URLFetcherUsingMediaContextDuringShutdown) { 525 URLFetcherUsingMediaContextDuringShutdown) {
526 StartActiveFetcherDuringProfileShutdownTest( 526 StartActiveFetcherDuringProfileShutdownTest(
527 browser()->profile()->GetMediaRequestContext()); 527 browser()->profile()->GetMediaRequestContext());
528 } 528 }
529 529
530 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
eroman 2016/03/26 00:55:16 Why the removals?
mmenke 2016/03/28 17:33:11 git meltdown...These are from another CL...Grr. R
531 URLFetcherUsingExtensionContextDuringShutdown) {
532 StartActiveFetcherDuringProfileShutdownTest(
533 browser()->profile()->GetRequestContextForExtensions());
534 }
535
536 // The following tests make sure that it's safe to destroy an incognito profile 530 // The following tests make sure that it's safe to destroy an incognito profile
537 // while one of the its URLRequestContextGetters is in use by a URLFetcher. 531 // while one of the its URLRequestContextGetters is in use by a URLFetcher.
538 532
539 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, 533 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
540 URLFetcherUsingMainContextDuringIncognitoTeardown) { 534 URLFetcherUsingMainContextDuringIncognitoTeardown) {
541 Browser* incognito_browser = 535 Browser* incognito_browser =
542 OpenURLOffTheRecord(browser()->profile(), GURL("about:blank")); 536 OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));
543 RunURLFetcherActiveDuringIncognitoTeardownTest( 537 RunURLFetcherActiveDuringIncognitoTeardownTest(
544 incognito_browser, incognito_browser->profile()->GetRequestContext()); 538 incognito_browser, incognito_browser->profile()->GetRequestContext());
545 } 539 }
546
547 IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
548 URLFetcherUsingExtensionContextDuringIncognitoTeardown) {
549 Browser* incognito_browser =
550 OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));
551
552 RunURLFetcherActiveDuringIncognitoTeardownTest(
553 incognito_browser,
554 incognito_browser->profile()->GetRequestContextForExtensions());
555 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/url_request_adapter.h » ('j') | net/base/chunked_upload_data_stream.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698